fix: tests

grafana · Jan 7, 2025 · 9f543f1 · 9f543f1
1 parent 409dc0b
commit 9f543f1
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/src/components/CheckForm/AlertsPerCheck/AlertItem.tsx b/src/components/CheckForm/AlertsPerCheck/AlertItem.tsx
@@ -53,6 +53,7 @@ export const AlertItem = ({
                 <Input
                   aria-disabled={!selected}
                   type="number"
+                  step="any"
                   id={`alert-threshold-${alert.type}`}
                   value={field.value ? field.value : threshold}
                   onChange={(e) => {
@@ -84,7 +85,6 @@ const getStyles = (theme: GrafanaTheme2) => ({
     display: 'flex',
     alignItems: 'center',
     gap: theme.spacing(1),
-    marginBottom: theme.spacing(1),
   }),
 
   columnLabel: css({
@@ -95,7 +95,6 @@ const getStyles = (theme: GrafanaTheme2) => ({
   }),
 
   thresholdInput: css({
-    height: '50px',
     marginLeft: '22px',
   }),
 });
diff --git a/src/page/NewCheck/__tests__/ApiEndPointChecks/CommonFields.payload.test.tsx b/src/page/NewCheck/__tests__/ApiEndPointChecks/CommonFields.payload.test.tsx
@@ -104,6 +104,7 @@ describe('Api endpoint checks - common fields payload', () => {
 
           const thresholdsInput = screen.getAllByLabelText(/^Threshold/)[0];
 
+          await user.click(screen.getByLabelText('ProbeFailedExecutionsTooHigh'));
           await user.clear(thresholdsInput);
           await user.type(thresholdsInput, '0.1');
 

diff --git a/src/page/NewCheck/__tests__/ApiEndPointChecks/HTTPCheck/4-alerting.payload.test.tsx b/src/page/NewCheck/__tests__/ApiEndPointChecks/HTTPCheck/4-alerting.payload.test.tsx
@@ -40,15 +40,19 @@ describe(`HttpCheck - Section 4 (Alerting) payload`, () => {
 
     expect(thresholdsInputs).toHaveLength(6);
 
+    await user.click(screen.getByLabelText('ProbeFailedExecutionsTooHigh'));
     await user.clear(thresholdsInputs[0]);
     await user.type(thresholdsInputs[0], '0.1');
 
+    await user.click(screen.getByLabelText('HTTPTargetCertificateCloseToExpiring'));
     await user.clear(thresholdsInputs[1]);
     await user.type(thresholdsInputs[1], '1');
 
+    await user.click(screen.getByLabelText('HTTPRequestDurationTooHighP50'));
     await user.clear(thresholdsInputs[2]);
     await user.type(thresholdsInputs[2], '2');
 
+    await user.click(screen.getByLabelText('HTTPRequestDurationTooHighP90'));
     await user.clear(thresholdsInputs[3]);
     await user.type(thresholdsInputs[3], '3');
 
@@ -61,15 +65,15 @@ describe(`HttpCheck - Section 4 (Alerting) payload`, () => {
         { name: 'ProbeFailedExecutionsTooHigh', threshold: 0.1 },
         {
           name: 'HTTPRequestDurationTooHighP50',
-          threshold: 1,
+          threshold: 2,
         },
         {
           name: 'HTTPRequestDurationTooHighP90',
-          threshold: 2,
+          threshold: 3,
         },
         {
-          name: 'HTTPRequestDurationTooHighP95',
-          threshold: 3,
+          name: 'HTTPTargetCertificateCloseToExpiring',
+          threshold: 1,
         },
       ],
     });

diff --git a/src/page/NewCheck/__tests__/ApiEndPointChecks/PingCheck/4-alerting.payload.test.tsx b/src/page/NewCheck/__tests__/ApiEndPointChecks/PingCheck/4-alerting.payload.test.tsx
@@ -7,7 +7,7 @@ import { fillMandatoryFields } from '../../../../__testHelpers__/apiEndPoint';
 
 const checkType = CheckType.PING;
 
-describe(`HttpCheck - Section 4 (Alerting) payload`, () => {
+describe(`PingCheck - Section 4 (Alerting) payload`, () => {
   it(`has the correct default values`, async () => {
     const { read, user } = await renderNewForm(checkType);
     await fillMandatoryFields({ user, checkType });
@@ -40,15 +40,19 @@ describe(`HttpCheck - Section 4 (Alerting) payload`, () => {
 
     expect(thresholdsInputs).toHaveLength(5);
 
+    await user.click(screen.getByLabelText('ProbeFailedExecutionsTooHigh'));
     await user.clear(thresholdsInputs[0]);
     await user.type(thresholdsInputs[0], '0.1');
 
+    await user.click(screen.getByLabelText('PingICMPDurationTooHighP50'));
     await user.clear(thresholdsInputs[1]);
     await user.type(thresholdsInputs[1], '1');
 
+    await user.click(screen.getByLabelText('PingICMPDurationTooHighP90'));
     await user.clear(thresholdsInputs[2]);
     await user.type(thresholdsInputs[2], '2');
 
+    await user.click(screen.getByLabelText('PingICMPDurationTooHighP95'));
     await user.clear(thresholdsInputs[3]);
     await user.type(thresholdsInputs[3], '3');