Add retries to BBE DNS probe #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem
force-pushed
the
mem/add-retries-to-bbe-dns-probe
branch
5 times, most recently
from
1c48b13 to
3696267
Compare
Copy the BBE DNS probe code to modify it in order to add retry logic. We can try to upstream this, that's why this is not adding any metrics yet. This will retry 3 times if there's enough time (at least 15 seconds). No DNS check should actually take more than 5 seconds, so when we see a long timeout, inject the retry logic in there. This experimental DNS prober is behind a feature flag called "experimental-dns-prober". The existing behavior is the default. Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
mem/add-retries-to-bbe-dns-probe
branch
from
3696267 to
0d818c1
Compare
mem
added a commit
that referenced
this pull request
Jul 30, 2024
* ci/renovate: update gomod digests before 8 AM UTC * Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.16.0 (#800) * Info message for -features used deprecated syntax. (#801) * Update golang.org/x/exp digest to 8a7402a (#806) * k6runner: handle ErrorCodeFailed (#791) * Add retries to BBE DNS probe (#803) * Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.17.1 (#808) * Update github.com/grafana/loki/pkg/push digest to 5a87ccb (#804) Signed-off-by: Marcelo E. Magallon <[email protected]>
Merged
mem
added a commit
that referenced
this pull request
Jul 30, 2024
* ci/renovate: update gomod digests before 8 AM UTC * Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.16.0 (#800) * Info message for -features used deprecated syntax. (#801) * Update golang.org/x/exp digest to 8a7402a (#806) * k6runner: handle ErrorCodeFailed (#791) * Add retries to BBE DNS probe (#803) * Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.17.1 (#808) * Update github.com/grafana/loki/pkg/push digest to 5a87ccb (#804) Signed-off-by: Marcelo E. Magallon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the BBE DNS probe code to modify it in order to add retry logic. We can try to upstream this, that's why this is not adding any metrics yet.
This will retry 3 times if there's enough time (at least 15 seconds). No DNS check should actually take more than 5 seconds, so when we see a long timeout, inject the retry logic in there.