Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip interpolating multihttp variables into the metric names #683

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

rdubrock
Copy link
Contributor

Having the actual URL here can lead to an active series explosion. If a variable is passed as part of the URL that changes on each run, it means new active series will get generated every time the check executes. To stop this, we should use the un-interpolated value as the metric name.

In pseudo code example:

var random := randomNumber()

url := https://www/example.com/{{ random }}

makeRequest(url) // Here the request will actually go to https://www.example.com/3252
reportMetrics("https://www/example.com/{{ random }}") // metric values will be reported as { url="https://www.example.com/{{random}}" }

@rdubrock rdubrock requested a review from a team as a code owner April 15, 2024 21:53
@rdubrock rdubrock force-pushed the skip-interpolation-in-metric-names branch from 148972f to c049b37 Compare April 15, 2024 22:45
Copy link
Contributor

@mem mem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

@mem mem merged commit eea5b63 into main Apr 16, 2024
4 checks passed
@mem mem deleted the skip-interpolation-in-metric-names branch April 16, 2024 17:00
The-9880 added a commit that referenced this pull request Apr 17, 2024
* Feature: upgrade k6 to v0.50.0 (#681)
* Chore(deps): Bump github.com/prometheus/blackbox_exporter
* skip interpolating multihttp variables into the metric names (#683)
* proto fields for scripted check enablement (#674)
* Switch to using buf to manage protobuf code (#641)

Signed-off-by: Anant Sharma <[email protected]>
@The-9880 The-9880 mentioned this pull request Apr 17, 2024
The-9880 added a commit that referenced this pull request Apr 17, 2024
* Feature: upgrade k6 to v0.50.0 (#681)
* Chore(deps): Bump github.com/prometheus/blackbox_exporter
* skip interpolating multihttp variables into the metric names (#683)
* proto fields for scripted check enablement (#674)
* Switch to using buf to manage protobuf code (#641)

Signed-off-by: Anant Sharma <[email protected]>
The-9880 added a commit that referenced this pull request Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681)
* Chore(deps): Bump github.com/prometheus/blackbox_exporter
* skip interpolating multihttp variables into the metric names (#683)
* proto fields for scripted check enablement (#674)
* Switch to using buf to manage protobuf code (#641)
* Release v0.23.4 (#685)
* Fix: TestTickWithOffset sometimes if offset is 0 (#686)
* Chore(deps): Bump the prometheus-go group with 2 updates
* Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59
* Log configuration at start up (#689)
* Feature: automatically set up GOMEMLIMIT (#691)
* Terminate agent if capabilities not supported (#684)
* Make k6 capability validation nil-safe (#692)
* Fix: use uniform timeout validation logic (#693)

Signed-off-by: Anant Sharma <[email protected]>
@The-9880 The-9880 mentioned this pull request Apr 30, 2024
The-9880 added a commit that referenced this pull request Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681)
* Chore(deps): Bump github.com/prometheus/blackbox_exporter
* skip interpolating multihttp variables into the metric names (#683)
* proto fields for scripted check enablement (#674)
* Switch to using buf to manage protobuf code (#641)
* Release v0.23.4 (#685)
* Fix: TestTickWithOffset sometimes if offset is 0 (#686)
* Chore(deps): Bump the prometheus-go group with 2 updates
* Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59
* Log configuration at start up (#689)
* Feature: automatically set up GOMEMLIMIT (#691)
* Terminate agent if capabilities not supported (#684)
* Make k6 capability validation nil-safe (#692)
* Fix: use uniform timeout validation logic (#693)

Signed-off-by: Anant Sharma <[email protected]>
@The-9880 The-9880 mentioned this pull request Apr 30, 2024
The-9880 added a commit that referenced this pull request Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681)
* Chore(deps): Bump github.com/prometheus/blackbox_exporter
* skip interpolating multihttp variables into the metric names (#683)
* proto fields for scripted check enablement (#674)
* Switch to using buf to manage protobuf code (#641)
* Release v0.23.4 (#685)
* Fix: TestTickWithOffset sometimes if offset is 0 (#686)
* Chore(deps): Bump the prometheus-go group with 2 updates
* Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59
* Log configuration at start up (#689)
* Feature: automatically set up GOMEMLIMIT (#691)
* Terminate agent if capabilities not supported (#684)
* Make k6 capability validation nil-safe (#692)
* Fix: use uniform timeout validation logic (#693)
* k6runner: handle errors reported by http runners
* k6runner/test: add test for RunResponse error handling
* k6runner: inspect errors and propagate unexpected ones to the probe

Signed-off-by: Anant Sharma <[email protected]>
@The-9880 The-9880 mentioned this pull request Apr 30, 2024
mem pushed a commit that referenced this pull request Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681)
* Chore(deps): Bump github.com/prometheus/blackbox_exporter
* skip interpolating multihttp variables into the metric names (#683)
* proto fields for scripted check enablement (#674)
* Switch to using buf to manage protobuf code (#641)
* Release v0.23.4 (#685)
* Fix: TestTickWithOffset sometimes if offset is 0 (#686)
* Chore(deps): Bump the prometheus-go group with 2 updates
* Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59
* Log configuration at start up (#689)
* Feature: automatically set up GOMEMLIMIT (#691)
* Terminate agent if capabilities not supported (#684)
* Make k6 capability validation nil-safe (#692)
* Fix: use uniform timeout validation logic (#693)
* k6runner: handle errors reported by http runners
* k6runner/test: add test for RunResponse error handling
* k6runner: inspect errors and propagate unexpected ones to the probe

Signed-off-by: Anant Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants