Fix: fix http status code parsing for publish #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
added a commit
that referenced
this pull request
Apr 26, 2022
* Bump kernel.org/pub/linux/libs/security/libcap/cap from 1.2.63 to 1.2.64 * Chore(deps): Bump google.golang.org/grpc from 1.45.0 to 1.46.0 * Bump github.com/miekg/dns from 1.1.47 to 1.1.48 (#277) * Fix linter errors * Fix build error * Add metric to track prometheus client retries (#282) * dialer for grpc? * feat: Add a metric for failure to publish data (#280) * Fix: fix http status code parsing for publish (#279) Signed-off-by: Suraj Nath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a temporary fix where we were looking at error string to check if we were getting 401 from server.
sm_agent_publisher_push_errors_totalmetric is still broken after the temporary fix, and it was reporting0as status for all errors.In this change, I am fixing the status code parsing code, and getting rid of temporary fix.