Feature: automatically set up GOMEMLIMIT #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs #689 |
mem
force-pushed
the
setup-auto-memlimit
branch
from
aa7af33 to
06c8d48
Compare
mem
changed the title
mem
force-pushed
the
setup-auto-memlimit
branch
from
06c8d48 to
a9a038b
Compare
Automatically set up GOMEMLIMIT to 90% of the cgroup allowed memory. If running in an environment where there's no cgroup limit set up, fallback to 90% of the system's memory. Note that this doesn't mean that the program will use 90% of the system's memory, but that if it does get to that point, the garbaga collector will try to be more aggresive. It is strongly recommended to set a limit via cgroups. Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
setup-auto-memlimit
branch
from
a9a038b to
00ecc8a
Compare
The-9880
approved these changes
Apr 19, 2024
The-9880
added a commit
that referenced
this pull request
Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681) * Chore(deps): Bump github.com/prometheus/blackbox_exporter * skip interpolating multihttp variables into the metric names (#683) * proto fields for scripted check enablement (#674) * Switch to using buf to manage protobuf code (#641) * Release v0.23.4 (#685) * Fix: TestTickWithOffset sometimes if offset is 0 (#686) * Chore(deps): Bump the prometheus-go group with 2 updates * Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59 * Log configuration at start up (#689) * Feature: automatically set up GOMEMLIMIT (#691) * Terminate agent if capabilities not supported (#684) * Make k6 capability validation nil-safe (#692) * Fix: use uniform timeout validation logic (#693) Signed-off-by: Anant Sharma <[email protected]>
Closed
The-9880
added a commit
that referenced
this pull request
Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681) * Chore(deps): Bump github.com/prometheus/blackbox_exporter * skip interpolating multihttp variables into the metric names (#683) * proto fields for scripted check enablement (#674) * Switch to using buf to manage protobuf code (#641) * Release v0.23.4 (#685) * Fix: TestTickWithOffset sometimes if offset is 0 (#686) * Chore(deps): Bump the prometheus-go group with 2 updates * Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59 * Log configuration at start up (#689) * Feature: automatically set up GOMEMLIMIT (#691) * Terminate agent if capabilities not supported (#684) * Make k6 capability validation nil-safe (#692) * Fix: use uniform timeout validation logic (#693) Signed-off-by: Anant Sharma <[email protected]>
Closed
The-9880
added a commit
that referenced
this pull request
Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681) * Chore(deps): Bump github.com/prometheus/blackbox_exporter * skip interpolating multihttp variables into the metric names (#683) * proto fields for scripted check enablement (#674) * Switch to using buf to manage protobuf code (#641) * Release v0.23.4 (#685) * Fix: TestTickWithOffset sometimes if offset is 0 (#686) * Chore(deps): Bump the prometheus-go group with 2 updates * Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59 * Log configuration at start up (#689) * Feature: automatically set up GOMEMLIMIT (#691) * Terminate agent if capabilities not supported (#684) * Make k6 capability validation nil-safe (#692) * Fix: use uniform timeout validation logic (#693) * k6runner: handle errors reported by http runners * k6runner/test: add test for RunResponse error handling * k6runner: inspect errors and propagate unexpected ones to the probe Signed-off-by: Anant Sharma <[email protected]>
Merged
mem
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681) * Chore(deps): Bump github.com/prometheus/blackbox_exporter * skip interpolating multihttp variables into the metric names (#683) * proto fields for scripted check enablement (#674) * Switch to using buf to manage protobuf code (#641) * Release v0.23.4 (#685) * Fix: TestTickWithOffset sometimes if offset is 0 (#686) * Chore(deps): Bump the prometheus-go group with 2 updates * Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59 * Log configuration at start up (#689) * Feature: automatically set up GOMEMLIMIT (#691) * Terminate agent if capabilities not supported (#684) * Make k6 capability validation nil-safe (#692) * Fix: use uniform timeout validation logic (#693) * k6runner: handle errors reported by http runners * k6runner/test: add test for RunResponse error handling * k6runner: inspect errors and propagate unexpected ones to the probe Signed-off-by: Anant Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically set up GOMEMLIMIT to 90% of the cgroup allowed memory. If
running in an environment where there's no cgroup limit set up, fallback
to 90% of the system's memory. Note that this doesn't mean that the
program will use 90% of the system's memory, but that if it does get to
that point, the garbaga collector will try to be more aggresive.
It is strongly recommended to set a limit via cgroups.
Signed-off-by: Marcelo E. Magallon [email protected]