Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: bump minor, not patch, for features
From the wonderful world of "we have opinions but we don't document them" comes "we provide a sane default configuration but we don't document it." When 5c21ba3 introduced a configuration file for release please, it replaced a built-in default configuration, which does not consist of the default values but a particular set of hand-picked values, with one where default values suddenly apply. In other words, by having an explicit configuration, all the options for which a value is not supplied use the default value. By *not* having a configuration, a predefined one is used, which is not composed of all the default values for all the options. I do not have the time to figure out where this default configuration comes from, but I can see that it does one thing if an empty configuration is provided and a different thing if no configuration is provided. At first glance, it seems to be the CLI flags but I do not know. Part of that sane default configuration is that when a feature is added, the minor version should be bumped, even if there hasn't been a major release yet. The default value, bump patch unless there's has been a major release already, is indeed a surprising bad default. Signed-off-by: Marcelo E. Magallon <[email protected]>
- Loading branch information