Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Grafana Faro #21

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Add Grafana Faro #21

merged 3 commits into from
Aug 31, 2023

Conversation

mdcruz
Copy link
Collaborator

@mdcruz mdcruz commented Aug 4, 2023 •
edited
Loading

On the Faro Grafana UI, please follow the instructions listed here to set it up on your own Grafana instance.

You can find the URL on the Web SDK configuration view:

Screenshot 2023-08-04 at 18 21 11

Then, before running the docker container, export the QUICKPIZZA_CONF_FARO_URL env var to your container.

Here's an example session:

faro-quickpizza.mov

@mdcruz mdcruz changed the title setup faro Add Grafana Faro Aug 4, 2023
@mdcruz mdcruz requested a review from dgzlopes August 4, 2023 10:29
@mdcruz mdcruz linked an issue Aug 4, 2023 that may be closed by this pull request
Add Grafana Faro to the frontend #14
Closed
@dgzlopes dgzlopes requested a review from roobre August 7, 2023 07:36
@roobre
Copy link
Member

roobre commented Aug 30, 2023

@mdcruz @dgzlopes I've pushed 141d79f, that makes a small change to the init code to fetch the faro_url. I totally have no idea of what I'm doing with svelte, so please feel free to point out any javascript war crimes I might have commited.

mdcruz
mdcruz commented Aug 30, 2023
View reviewed changes
.env.local Outdated Show resolved Hide resolved
mdcruz
mdcruz commented Aug 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
mdcruz
mdcruz commented Aug 30, 2023
View reviewed changes
Copy link
Collaborator Author

@mdcruz mdcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks, thank you so much @roobre! 💜

pkg/web/src/hooks.client.ts Outdated Show resolved Hide resolved
pkg/web/src/hooks.client.ts Outdated Show resolved Hide resolved
@roobre
Copy link
Member

roobre commented Aug 30, 2023 •
edited
Loading

@mdcruz Thanks for your comments! I think I've fixed everything you pointed out, LMK if everything looks shiny now 😃

@mdcruz
Copy link
Collaborator Author

mdcruz commented Aug 31, 2023

@mdcruz Thanks for your comments! I think I've fixed everything you pointed out, LMK if everything looks shiny now 😃

All good thanks so much!

@mdcruz
Copy link
Collaborator Author

mdcruz commented Aug 31, 2023

@roobre I can't approved it since I opened the PR. Feel fee to approve and merge it 😊

dgzlopes
dgzlopes approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@dgzlopes dgzlopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

mdcruz and others added 3 commits August 31, 2023 17:10
@mdcruz @roobre
add Grafana Faro
7bff635
@roobre
frontend/faro: read faro_url from /api/config
d1161e8 
Faro URL can be provided by starting the backend with the env var QUICKPIZZA_CONF_FARO_URL set to the desired Faro URL.
@roobre
README: update section on how to enable Faro
95ccf06
@roobre roobre merged commit 13dce41 into main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgzlopes dgzlopes dgzlopes approved these changes

@roobre roobre roobre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Grafana Faro to the frontend
3 participants
@mdcruz @roobre @dgzlopes