chore(goreleaser): Fix error handling during release #3950
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20250225_error-handling-goreleaser
branch
from
377e1c8 to
96f34df
Compare
simonswine
changed the title
alsoba13
approved these changes
Feb 25, 2025
simonswine
force-pushed
the
20250225_error-handling-goreleaser
branch
from
06fa157 to
37e660f
Compare
|
It took a bit more and a few tries: This is the error case: https://github.com/grafana/pyroscope/actions/runs/13527124425/job/37800413661 and this is when the build is fine: https://github.com/grafana/pyroscope/actions/runs/13527418259/job/37801366464 |
kolesnikovae
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This weeks release, did fail but the CI pipeline was successful. This change "should" prevent this from happening.
I will reproduce it and doublecheck the CI build fails