feat: tenant settings ruler #3944
Closed
+1,139
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* metrics for exporter client * use promhttp instrumented round tripper * remove custom round tripper, add TODO
alsoba13
force-pushed
the
alsoba13/tenant-settings-ruler
branch
from
164b987 to
415f1a3
Compare
Base automatically changed from
alsoba13/metrics-from-profiles-record-and-export
to
main
February 24, 2025 16:16
simonswine
reviewed
Feb 24, 2025
Comment on lines
+113
to
+116
| if c.value != nil && time.Now().Before(c.ttl) { | ||
| // value exists and didn't expired | ||
| return c.value | ||
| } |
There was a problem hiding this comment.
I think you want to hold theRLock for this
There was a problem hiding this comment.
absolutely. As this was only one file and I started from an already squashed branch to merge, I've created a new branch and PR #3945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tenant settings ruler is a thread-safe ruler that obtains rules from tenant-settings service and caches the result for later calls.
It holds a cache for each tenant, that expires after the default time (60s).
Every first call to a tenant for
RecordingRules(tenant string)will initialize the per-tenant cache. When calling again the method, the cached rules will be served unless they expired. In that case, cache will be refreshed.I discarded doing generics here becase (1) I would like to validate the idea and (2) there's no need to generalize the cache.