fix: migrate to pprof2 crate
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original `pprof` crate is long abandoned and doesn't work with recent toolchains. There is a new `pprof2` crate that contains fixes and works with recent toolchains. Fixes grafana#174
korniltsev
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
lgtm
further update to 0.14 could be useful to include this fix tikv/pprof-rs@b1d02fd
|
Yes, when I tested and created this PR, the original upstream still appeared inactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
pprofcrate is long abandoned and doesn't work with recent toolchains. There is a newpprof2crate that contains fixes and works with recent toolchains.Fixes #174