Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump py-spy to support python 3.12 and 3.13 #181

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

XieJiSS
Copy link
Contributor

@XieJiSS XieJiSS commented Nov 4, 2024

see-also: benfred/py-spy#642
see-also: benfred/py-spy#713

Fixes #168

also bumped inferno because py-spy 0.4.0 requires inferno 0.11.21

@XieJiSS XieJiSS requested review from a team as code owners November 4, 2024 04:44
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mattiasnensen
Copy link

Please have a look at this! Really needed

@XieJiSS
Copy link
Contributor Author

XieJiSS commented Nov 20, 2024

Looks like the failing tests are not related to this PR

@mtralka
Copy link
Contributor

mtralka commented Nov 20, 2024

I believe the test failures are expected due to underlying runner changes re: #179 (comment)

@korniltsev do you have the bandwidth to review this change and potentially unblock Python 3.12 support for pyroscope?

@korniltsev korniltsev merged commit 21c562e into grafana:main Nov 20, 2024
3 of 11 checks passed
@korniltsev
Copy link
Collaborator

The CI is broken, I am not sure when I will be able to look into it and fix it and then release it.

@mtralka
Copy link
Contributor

mtralka commented Nov 20, 2024

The CI is broken, I am not sure when I will be able to look into it and fix it and then release it.

Thank you for your candidacy! I've opened a draft PR - #184 - to fix the immediate issues as I see them. May be more hidden under there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported version of Python: 3.12.0
5 participants