jsonnet: Remove configuration to use Redis from jsonnet #9677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove conditionals that allowed Redis to be set as a cache backend from jsonnet. Note that this does not remove support for Redis from Mimir as that will be done in a later release, this only affects jsonnet. Related #9453
56quarters
force-pushed
the
56quarters/redis-jsonnet
branch
from
576dbf6 to
b1f5684
Compare
narqo
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
🔥 As discussed on a side
We don't plan to remove the flags from mimir until the next major release. But the jsonnet has no guarantee of backwards compatibility and we never had jsonnet to create redis sts/deployments. It only configures mimir to point at an existing redis setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Remove conditionals that allowed Redis to be set as a cache backend from jsonnet. Note that this does not remove support for Redis from Mimir as that will be done in a later release, this only affects jsonnet.
Which issue(s) this PR fixes or relates to
Related #9453
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.