remove non-ascii characters from invalid metric names in error message #7146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a metric with a non-ascii characters gets received the input validation correctly rejects it, but depending on the invalid character the serialization of the generated error message can fail, for example:
This change removes the non-ascii characters from the metric name when generating the invalid metric name error message. It appends the string
(non-ascii characters removed)
to the modified metric name in the error message because if we'd just return the cleaned up string as part of the error message then the user who's looking at the error might not understand what the problem was.