-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for Alertmanager GRPC client and GET request concurrency #1547
Add configuration for Alertmanager GRPC client and GET request concurrency #1547
Conversation
…rency Tuning these parameters is useful when alertmanager is under heavy load
docs/sources/operators-guide/configuring/reference-configuration-parameters/index.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please see my nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (modulo few nits)
Co-authored-by: Marco Pracucci <[email protected]>
Co-authored-by: Marco Pracucci <[email protected]>
Co-authored-by: gotjosh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job, let's go!
What this PR does
Exposes existing configuration via yaml and CLI flags:
Tuning these parameters is useful when alertmanager is under heavy load
Which issue(s) this PR fixes or relates to
Fixes https://github.com/grafana/mimir-squad/issues/578
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]