Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-driver compose labels support #970

Merged
merged 1 commit into from
Sep 5, 2019
Merged

docker-driver compose labels support #970

merged 1 commit into from
Sep 5, 2019

Conversation

mindfl
Copy link
Contributor

@mindfl mindfl commented Sep 5, 2019

What this PR does / why we need it:

It's a trivial improvement for support docker compose labels in the loki docker-driver.

Which issue(s) this PR fixes:

Fixes #922

Special notes for your reviewer:

I don't have Go programming skills, but it's really simple fix, I think. Changes tested by manualy build, push, and install plugin.

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2019

CLA assistant check
All committers have signed the CLA.

@mindfl mindfl changed the title resolve: #922. docker-driver compose labels support docker-driver compose labels support Sep 5, 2019
@cyriltovena
Copy link
Contributor

Nice what's a compose project ? a global name for a given compose file ?

@mindfl
Copy link
Contributor Author

mindfl commented Sep 5, 2019

Nice what's a compose project ? a global name for a given compose file ?

It's a project name option from docker-compose command:

  -p, --project-name NAME     Specify an alternate project name
                              (default: directory name)

Loki label -> docker compose label:

  • compose_project -> com.docker.compose.project
  • compose_service -> com.docker.compose.service

@cyriltovena
Copy link
Contributor

You need to CLA. I'll will take a look at it.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complex labels option for docker configuration
3 participants