Fix configmap checksum in table manager deployment template #9579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NilsGriebner
changed the title
NilsGriebner
force-pushed
the
fix-table-manager-deployment-template
branch
from
81fdddb to
ed4e496
Compare
NilsGriebner
force-pushed
the
fix-table-manager-deployment-template
branch
from
7692ff9 to
95d5f8f
Compare
NilsGriebner
force-pushed
the
fix-table-manager-deployment-template
branch
from
95d5f8f to
92a6381
Compare
NilsGriebner
force-pushed
the
fix-table-manager-deployment-template
branch
from
92a6381 to
444d31f
Compare
6 tasks
MichelHollands
added a commit
that referenced
this pull request
Jun 7, 2023
**What this PR does / why we need it**: @NilsGriebner : complement to #9579 **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) --------- Co-authored-by: Michel Hollands <[email protected]>
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
…9579) **What this PR does / why we need it**: This PR fixes the path to the configmap template in table-manager deployment file **Which issue(s) this PR fixes**: Fixes grafana#9578 **Special notes for your reviewer**: This is probably the same issue as in grafana#9546. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@2cef71e)
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
**What this PR does / why we need it**: @NilsGriebner : complement to grafana#9579 **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@2cef71e) --------- Co-authored-by: Michel Hollands <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the path to the configmap template in table-manager deployment file
Which issue(s) this PR fixes:
Fixes #9578
Special notes for your reviewer:
This is probably the same issue as in #9546.
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR