fix packaging of armv7 distribution packages #8858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm unsure if I should add
Hopefully this can get the backport release-2.8.x label by some Maintainer. |
jeschkies
reviewed
Aug 30, 2023
| @@ -61,7 +61,7 @@ local arch = std.extVar('arch'); | |||
|
|
|||
| { | |||
| name: name, | |||
| arch: arch, | |||
| arch: if arch == 'arm' then 'arm7' else arch, | |||
There was a problem hiding this comment.
@julienduchesne where's the arm defined? Maybe we should fix it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Until now, the
armv7deb/rpm packages on the GitHub release page have the wrong architecturearm.This is because
nfpmexpectsarm7instead ofarm(see docs). Hence,nfpmcannot correctly convert the arch to its individual distribution counterpart (armhf/armv7hl/...).Which issue(s) this PR fixes:
Fixes partially #7705
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md