Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtail: restore ability to show target labels in promtail UI #804

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jul 26, 2019

PR #791 accidentally removed the ability to use the promtail UI by removing methods from the Target interface that were only used within the HTML templates.

Along with restoring the methods in the Target interface, this commit also introduces details for the JournalTarget, which currently only provides the position in the journal being tracked.

@rfratto rfratto requested a review from cyriltovena July 26, 2019 18:35
PR grafana#791 accidentally removed the ability to use the promtail UI
by removing methods from the Target interface that were only
used within the HTML templates.

Along with restoring the methods in the Target interface, this
commit also introduces details for the JournalTarget, which
currently only provides the position in the journal being
tracked.
@rfratto rfratto force-pushed the discovered-labels-fix branch from 5ea8018 to 069eb35 Compare July 26, 2019 18:39
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit f2bec3b into grafana:master Jul 26, 2019
@rfratto rfratto deleted the discovered-labels-fix branch July 26, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants