Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/docker-driver/README.md: fix typo #773

Closed
wants to merge 1 commit into from

Conversation

bbigras
Copy link

@bbigras bbigras commented Jul 17, 2019

I'm not sure 100% sure about this. I'm guessing it's a typo that you borrowed from https://docker.pkg.github.com/splunk/docker-logging-plugin#enable-debug-mode-to-find-log-errors.

I'm guessing it's a typo since it looked weird, google search for "LOGGIN_LEVEL" has less than 100 results, and that I wasn't able to find mention of it in Docker's doc (I wasn't able to find "LOGGIND_LEVEL" either).

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2019

CLA assistant check
All committers have signed the CLA.

@cyriltovena
Copy link
Contributor

I think both are incorrect :) Thanks for pointing this out. Looks like this is happening here : https://github.com/moby/moby/blob/master//cmd/dockerd/daemon.go#L714:6

Best way to find out is to try it out.

@cyriltovena
Copy link
Contributor

Actually I would remove the whole sentence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants