Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compactor: add per tenant compaction delete enabled flag (#6410) #6476

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

MichelHollands
Copy link
Contributor

  • Add per tenant compaction delete enabled flag

Signed-off-by: Michel Hollands [email protected]

  • Remove changes in wrong place

Signed-off-by: Michel Hollands [email protected]

  • Add compactor deletion enabled field

Signed-off-by: Michel Hollands [email protected]

  • Use limit in compactor

Signed-off-by: Michel Hollands [email protected]

  • Use http middleware and add test

Signed-off-by: Michel Hollands [email protected]

  • Fix lint issue

Signed-off-by: Michel Hollands [email protected]

  • Add changelog

Signed-off-by: Michel Hollands [email protected]

  • Revert to default setting if no override

Signed-off-by: Michel Hollands [email protected]

  • Add default value command line option

Signed-off-by: Michel Hollands [email protected]

  • Update the docs

Signed-off-by: Michel Hollands [email protected]

  • Enable access to deletion API for integration test

Signed-off-by: Michel Hollands [email protected]

  • Rename flag to allow_deletes

Signed-off-by: Michel Hollands [email protected]

  • Update per review comments

Signed-off-by: Michel Hollands [email protected]
(cherry picked from commit b4e6c59)

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

* Add per tenant compaction delete enabled flag

Signed-off-by: Michel Hollands <[email protected]>

* Remove changes in wrong place

Signed-off-by: Michel Hollands <[email protected]>

* Add compactor deletion enabled field

Signed-off-by: Michel Hollands <[email protected]>

* Use limit in compactor

Signed-off-by: Michel Hollands <[email protected]>

* Use http middleware and add test

Signed-off-by: Michel Hollands <[email protected]>

* Fix lint issue

Signed-off-by: Michel Hollands <[email protected]>

* Add changelog

Signed-off-by: Michel Hollands <[email protected]>

* Revert to default setting if no override

Signed-off-by: Michel Hollands <[email protected]>

* Add default value command line option

Signed-off-by: Michel Hollands <[email protected]>

* Update the docs

Signed-off-by: Michel Hollands <[email protected]>

* Enable access to deletion API for integration test

Signed-off-by: Michel Hollands <[email protected]>

* Rename flag to allow_deletes

Signed-off-by: Michel Hollands <[email protected]>

* Update per review comments

Signed-off-by: Michel Hollands <[email protected]>
(cherry picked from commit b4e6c59)
Signed-off-by: Michel Hollands <[email protected]>
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0.4%
+        distributor	0.3%
-            querier	-0.3%
- querier/queryrange	-0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0.2%
-               loki	-1.4%

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0.4%
-        distributor	-0.3%
-            querier	-0.3%
- querier/queryrange	-0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0.2%
-               loki	-0.7%

@MichelHollands MichelHollands merged commit df48f93 into grafana:k102 Jun 23, 2022
@vlad-diachenko vlad-diachenko added the backport release-2.6.x Tag a PR with this label to create a PR which cherry pics it into the release-2.6.x branch label Jun 24, 2022
grafanabot pushed a commit that referenced this pull request Jun 24, 2022
* Compactor: add per tenant compaction delete enabled flag (#6410)

* Add per tenant compaction delete enabled flag

Signed-off-by: Michel Hollands <[email protected]>

* Remove changes in wrong place

Signed-off-by: Michel Hollands <[email protected]>

* Add compactor deletion enabled field

Signed-off-by: Michel Hollands <[email protected]>

* Use limit in compactor

Signed-off-by: Michel Hollands <[email protected]>

* Use http middleware and add test

Signed-off-by: Michel Hollands <[email protected]>

* Fix lint issue

Signed-off-by: Michel Hollands <[email protected]>

* Add changelog

Signed-off-by: Michel Hollands <[email protected]>

* Revert to default setting if no override

Signed-off-by: Michel Hollands <[email protected]>

* Add default value command line option

Signed-off-by: Michel Hollands <[email protected]>

* Update the docs

Signed-off-by: Michel Hollands <[email protected]>

* Enable access to deletion API for integration test

Signed-off-by: Michel Hollands <[email protected]>

* Rename flag to allow_deletes

Signed-off-by: Michel Hollands <[email protected]>

* Update per review comments

Signed-off-by: Michel Hollands <[email protected]>
(cherry picked from commit b4e6c59)

* Fix changelog

Signed-off-by: Michel Hollands <[email protected]>
(cherry picked from commit df48f93)
vlad-diachenko pushed a commit that referenced this pull request Jun 24, 2022
…) (#6496)

* Compactor: add per tenant compaction delete enabled flag (#6410)

* Add per tenant compaction delete enabled flag

Signed-off-by: Michel Hollands <[email protected]>

* Remove changes in wrong place

Signed-off-by: Michel Hollands <[email protected]>

* Add compactor deletion enabled field

Signed-off-by: Michel Hollands <[email protected]>

* Use limit in compactor

Signed-off-by: Michel Hollands <[email protected]>

* Use http middleware and add test

Signed-off-by: Michel Hollands <[email protected]>

* Fix lint issue

Signed-off-by: Michel Hollands <[email protected]>

* Add changelog

Signed-off-by: Michel Hollands <[email protected]>

* Revert to default setting if no override

Signed-off-by: Michel Hollands <[email protected]>

* Add default value command line option

Signed-off-by: Michel Hollands <[email protected]>

* Update the docs

Signed-off-by: Michel Hollands <[email protected]>

* Enable access to deletion API for integration test

Signed-off-by: Michel Hollands <[email protected]>

* Rename flag to allow_deletes

Signed-off-by: Michel Hollands <[email protected]>

* Update per review comments

Signed-off-by: Michel Hollands <[email protected]>
(cherry picked from commit b4e6c59)

* Fix changelog

Signed-off-by: Michel Hollands <[email protected]>
(cherry picked from commit df48f93)

Co-authored-by: Michel Hollands <[email protected]>
@osg-grafana osg-grafana added type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories and removed area/docs labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.6.x Tag a PR with this label to create a PR which cherry pics it into the release-2.6.x branch size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants