-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compactor: add per tenant compaction delete enabled flag (#6410) #6476
Compactor: add per tenant compaction delete enabled flag (#6410) #6476
Conversation
* Add per tenant compaction delete enabled flag Signed-off-by: Michel Hollands <[email protected]> * Remove changes in wrong place Signed-off-by: Michel Hollands <[email protected]> * Add compactor deletion enabled field Signed-off-by: Michel Hollands <[email protected]> * Use limit in compactor Signed-off-by: Michel Hollands <[email protected]> * Use http middleware and add test Signed-off-by: Michel Hollands <[email protected]> * Fix lint issue Signed-off-by: Michel Hollands <[email protected]> * Add changelog Signed-off-by: Michel Hollands <[email protected]> * Revert to default setting if no override Signed-off-by: Michel Hollands <[email protected]> * Add default value command line option Signed-off-by: Michel Hollands <[email protected]> * Update the docs Signed-off-by: Michel Hollands <[email protected]> * Enable access to deletion API for integration test Signed-off-by: Michel Hollands <[email protected]> * Rename flag to allow_deletes Signed-off-by: Michel Hollands <[email protected]> * Update per review comments Signed-off-by: Michel Hollands <[email protected]> (cherry picked from commit b4e6c59)
Signed-off-by: Michel Hollands <[email protected]>
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0.4%
+ distributor 0.3%
- querier -0.3%
- querier/queryrange -0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0.2%
- loki -1.4% |
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0.4%
- distributor -0.3%
- querier -0.3%
- querier/queryrange -0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0.2%
- loki -0.7% |
* Compactor: add per tenant compaction delete enabled flag (#6410) * Add per tenant compaction delete enabled flag Signed-off-by: Michel Hollands <[email protected]> * Remove changes in wrong place Signed-off-by: Michel Hollands <[email protected]> * Add compactor deletion enabled field Signed-off-by: Michel Hollands <[email protected]> * Use limit in compactor Signed-off-by: Michel Hollands <[email protected]> * Use http middleware and add test Signed-off-by: Michel Hollands <[email protected]> * Fix lint issue Signed-off-by: Michel Hollands <[email protected]> * Add changelog Signed-off-by: Michel Hollands <[email protected]> * Revert to default setting if no override Signed-off-by: Michel Hollands <[email protected]> * Add default value command line option Signed-off-by: Michel Hollands <[email protected]> * Update the docs Signed-off-by: Michel Hollands <[email protected]> * Enable access to deletion API for integration test Signed-off-by: Michel Hollands <[email protected]> * Rename flag to allow_deletes Signed-off-by: Michel Hollands <[email protected]> * Update per review comments Signed-off-by: Michel Hollands <[email protected]> (cherry picked from commit b4e6c59) * Fix changelog Signed-off-by: Michel Hollands <[email protected]> (cherry picked from commit df48f93)
…) (#6496) * Compactor: add per tenant compaction delete enabled flag (#6410) * Add per tenant compaction delete enabled flag Signed-off-by: Michel Hollands <[email protected]> * Remove changes in wrong place Signed-off-by: Michel Hollands <[email protected]> * Add compactor deletion enabled field Signed-off-by: Michel Hollands <[email protected]> * Use limit in compactor Signed-off-by: Michel Hollands <[email protected]> * Use http middleware and add test Signed-off-by: Michel Hollands <[email protected]> * Fix lint issue Signed-off-by: Michel Hollands <[email protected]> * Add changelog Signed-off-by: Michel Hollands <[email protected]> * Revert to default setting if no override Signed-off-by: Michel Hollands <[email protected]> * Add default value command line option Signed-off-by: Michel Hollands <[email protected]> * Update the docs Signed-off-by: Michel Hollands <[email protected]> * Enable access to deletion API for integration test Signed-off-by: Michel Hollands <[email protected]> * Rename flag to allow_deletes Signed-off-by: Michel Hollands <[email protected]> * Update per review comments Signed-off-by: Michel Hollands <[email protected]> (cherry picked from commit b4e6c59) * Fix changelog Signed-off-by: Michel Hollands <[email protected]> (cherry picked from commit df48f93) Co-authored-by: Michel Hollands <[email protected]>
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
Signed-off-by: Michel Hollands [email protected]
(cherry picked from commit b4e6c59)
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CHANGELOG.md
.docs/sources/upgrading/_index.md