Add more logging for delete requests #6394

MichelHollands · 2022-06-14T14:50:34Z

What this PR does / why we need it:

Add more logging for the delete requests.

Checklist

Documentation added
Tests updated
Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

Signed-off-by: Michel Hollands [email protected]

Signed-off-by: Michel Hollands <[email protected]>

grafanabot · 2022-06-14T14:55:35Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot · 2022-06-14T14:56:45Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
-        distributor	-0.3%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot · 2022-06-14T15:22:33Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0.3%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

MasslessParticle

I think one of the logs could have a little more information but I think this looks good, otherwise.

pkg/storage/stores/shipper/compactor/deletion/delete_requests_manager.go

Signed-off-by: Michel Hollands <[email protected]>

grafanabot · 2022-06-15T08:31:02Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot · 2022-06-15T08:58:15Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

pkg/storage/stores/shipper/compactor/deletion/delete_request.go

vlad-diachenko

LGTM

pkg/storage/stores/shipper/compactor/deletion/delete_request.go

ssncferreira

LGTM

Signed-off-by: Michel Hollands <[email protected]>

grafanabot · 2022-06-15T09:22:35Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Signed-off-by: Michel Hollands <[email protected]>

dannykopping

LGTM, thanks @MichelHollands

grafanabot · 2022-06-15T09:29:57Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0.6%

Signed-off-by: Michel Hollands <[email protected]>

grafanabot · 2022-06-15T09:38:41Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
-        distributor	-0.3%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot · 2022-06-15T09:45:22Z

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
-        distributor	-0.3%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

* Add more logging for delete requests Signed-off-by: Michel Hollands <[email protected]> * Fix typo Signed-off-by: Michel Hollands <[email protected]> * Rephrase logging message and add chunk ID Signed-off-by: Michel Hollands <[email protected]> * Rename userID field to user Signed-off-by: Michel Hollands <[email protected]> * rename more userID Signed-off-by: Michel Hollands <[email protected]> * Fix existing log messages Signed-off-by: Michel Hollands <[email protected]> (cherry picked from commit 20db4df)

* Add more logging for delete requests Signed-off-by: Michel Hollands <[email protected]> * Fix typo Signed-off-by: Michel Hollands <[email protected]> * Rephrase logging message and add chunk ID Signed-off-by: Michel Hollands <[email protected]> * Rename userID field to user Signed-off-by: Michel Hollands <[email protected]> * rename more userID Signed-off-by: Michel Hollands <[email protected]> * Fix existing log messages Signed-off-by: Michel Hollands <[email protected]> (cherry picked from commit 20db4df) Co-authored-by: Michel Hollands <[email protected]>

* Add more logging for delete requests Signed-off-by: Michel Hollands <[email protected]> * Fix typo Signed-off-by: Michel Hollands <[email protected]> * Rephrase logging message and add chunk ID Signed-off-by: Michel Hollands <[email protected]> * Rename userID field to user Signed-off-by: Michel Hollands <[email protected]> * rename more userID Signed-off-by: Michel Hollands <[email protected]> * Fix existing log messages Signed-off-by: Michel Hollands <[email protected]> (cherry picked from commit 20db4df) Co-authored-by: Michel Hollands <[email protected]> (cherry picked from commit c707faf)

Add more logging for delete requests

86b2583

Signed-off-by: Michel Hollands <[email protected]>

pull-request-size bot added the size/M label Jun 14, 2022

Fix typo

37be992

Signed-off-by: Michel Hollands <[email protected]>

MichelHollands marked this pull request as ready for review June 14, 2022 14:51

MichelHollands requested a review from a team as a code owner June 14, 2022 14:51

MasslessParticle approved these changes Jun 14, 2022

View reviewed changes

pkg/storage/stores/shipper/compactor/deletion/delete_requests_manager.go Outdated Show resolved Hide resolved

Rephrase logging message and add chunk ID

cd5d874

Signed-off-by: Michel Hollands <[email protected]>

dannykopping reviewed Jun 15, 2022

View reviewed changes

pkg/storage/stores/shipper/compactor/deletion/delete_request.go Outdated Show resolved Hide resolved

vlad-diachenko approved these changes Jun 15, 2022

View reviewed changes

pkg/storage/stores/shipper/compactor/deletion/delete_request.go Show resolved Hide resolved

ssncferreira approved these changes Jun 15, 2022

View reviewed changes

Rename userID field to user

a1c4e86

Signed-off-by: Michel Hollands <[email protected]>

rename more userID

27def87

Signed-off-by: Michel Hollands <[email protected]>

dannykopping approved these changes Jun 15, 2022

View reviewed changes

Fix existing log messages

9c8fcb7

Signed-off-by: Michel Hollands <[email protected]>

dannykopping merged commit 20db4df into grafana:main Jun 15, 2022

MichelHollands added the backport k102 label Jun 23, 2022

grafanabot mentioned this pull request Jun 23, 2022

[k102] Add more logging for delete requests #6473

Merged

This was referenced Jun 28, 2022

dannykopping/remove cache stats dannykopping/loki#13

Closed

dannykopping/remove cache stats dannykopping/loki#14

Draft

Remove cache statistics PR from release-2.6.x #6525

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more logging for delete requests #6394

Add more logging for delete requests #6394

MichelHollands commented Jun 14, 2022

grafanabot commented Jun 14, 2022

grafanabot commented Jun 14, 2022

grafanabot commented Jun 14, 2022

MasslessParticle left a comment

grafanabot commented Jun 15, 2022

grafanabot commented Jun 15, 2022

vlad-diachenko left a comment

ssncferreira left a comment

grafanabot commented Jun 15, 2022

dannykopping left a comment

grafanabot commented Jun 15, 2022

grafanabot commented Jun 15, 2022

grafanabot commented Jun 15, 2022

Add more logging for delete requests #6394

Add more logging for delete requests #6394

Conversation

MichelHollands commented Jun 14, 2022

grafanabot commented Jun 14, 2022

grafanabot commented Jun 14, 2022

grafanabot commented Jun 14, 2022

MasslessParticle left a comment

Choose a reason for hiding this comment

grafanabot commented Jun 15, 2022

grafanabot commented Jun 15, 2022

vlad-diachenko left a comment

Choose a reason for hiding this comment

ssncferreira left a comment

Choose a reason for hiding this comment

grafanabot commented Jun 15, 2022

dannykopping left a comment

Choose a reason for hiding this comment

grafanabot commented Jun 15, 2022

grafanabot commented Jun 15, 2022

grafanabot commented Jun 15, 2022