specify logcli authorization header name by flag #6144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marco Cadetg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
- distributor -0.3%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
domcyrus
added a commit
to domcyrus/loki
that referenced
this pull request
May 14, 2022
|
Closed the PR due to the usage of a wrong commit email which I cannot use for the CLA. |
kavirajk
pushed a commit
that referenced
this pull request
May 16, 2022
* specify logcli authorization header by flag #6144 * default AuthHeader to Authorization in client lib * use constant for default auth header * for consistency use LOKI_AUTH_HEADER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logcli flag
auth-headerto be able to specify authorization header name.What this PR does / why we need it:
Adds a flag auth-header which defaults to Authorization.
Which issue(s) this PR fixes:
Fixes #6143
Special notes for your reviewer:
Change has no side effects on existing users unless they use the new flag auth-header.
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md