Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the labels timespan info #6019

Merged
merged 3 commits into from
May 4, 2022

Conversation

gabor
Copy link
Contributor

@gabor gabor commented Apr 26, 2022

When using the /loki/api/v1/labels and /loki/api/v1/label/$label_name/values HTTP endpoints, the time-range specified int the query is not always respected. in some cases a larger-than-specified time-range will be used. this pull request adds this into to the documentation.

Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting grammar and punctuation here. Use of the word "may" implies "in some cases," so we don't need that phrase either.

docs/sources/api/_index.md Outdated Show resolved Hide resolved
docs/sources/api/_index.md Outdated Show resolved Hide resolved
gabor and others added 2 commits April 28, 2022 10:33
Co-authored-by: Karen Miller <[email protected]>
Co-authored-by: Karen Miller <[email protected]>
@gabor gabor requested a review from KMiller-Grafana April 28, 2022 08:34
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @gabor

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KMiller-Grafana KMiller-Grafana merged commit 0a68bd2 into main May 4, 2022
@KMiller-Grafana KMiller-Grafana deleted the gabor/loki-docs-time-span branch May 4, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants