Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed gelfTarget of promtail #5992

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

vlad-diachenko
Copy link
Contributor

@vlad-diachenko vlad-diachenko commented Apr 22, 2022

What this PR does / why we need it:
Previously we had an issue if chunked messages were received not sequentially (if we receive chunked messages with different messageID).
Migrated gelfTarget to github.com/grafana/go-gelf/v2 library that contains the fix for chunked messages that was implemented in grafana/go-gelf#2 .

Which issue(s) this PR fixes:
Fixes #5644

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@vlad-diachenko vlad-diachenko requested a review from a team as a code owner April 22, 2022 11:04
@cyriltovena cyriltovena merged commit 4a91fdc into main Apr 25, 2022
@cyriltovena cyriltovena deleted the fixed_chunked_gelf_message_error branch April 25, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gelf support for long messages in Promtail broken, this is by design of the library used
3 participants