-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new build image 0.20.3 #5904
Conversation
29bbde6
to
f0f972e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, according to the build **logs** of you build image change. It pushed grafana/loki-build-image:0.20.2
And I know why. You didn't regenerate the drone.yml
🙈 make check-drone-drift
was supposed to catch that.
@@ -27,7 +27,7 @@ DOCKER_IMAGE_DIRS := $(patsubst %/Dockerfile,%,$(DOCKERFILES)) | |||
BUILD_IN_CONTAINER ?= true | |||
|
|||
# ensure you run `make drone` after changing this | |||
BUILD_IMAGE_VERSION := 0.20.1 | |||
BUILD_IMAGE_VERSION := 0.20.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you recent change just overrode 0.20.2
it should be that
BUILD_IMAGE_VERSION := 0.20.3 | |
BUILD_IMAGE_VERSION := 0.20.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.20.2 was built but never been used, see 4353916#diff-60045f9474705196e786df20a7bb40d29e013e47a3b6927153a10b9acac82266L358
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
f0f972e
to
b13e6b1
Compare
@@ -551,7 +551,7 @@ func (i *Ingester) Push(ctx context.Context, req *logproto.PushRequest) (*logpro | |||
return &logproto.PushResponse{}, err | |||
} | |||
|
|||
func (i *Ingester) GetOrCreateInstance(instanceID string) *instance { | |||
func (i *Ingester) GetOrCreateInstance(instanceID string) *instance { //nolint:revive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems unrelated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new linter version reports: unexported-return: exported method GetOrCreateInstance returns unexported type *ingester.instance
What this PR does / why we need it:
The new build image uses the latest version v1.45.2 of golangci-lint. With this version running the
make lint
locally yields the same results as running on CI.Special notes for your reviewer:
0.20.3
is builtThis PR contains commits from Update golangci-lint in build image #5901.drone/drone.yml
were generated bymake drone