Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 5077: improve default config values (#5077) #5104

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

trevorwhitney
Copy link
Collaborator

Backports 5077 into 2.4 release for 2.4.2

* improve default config values

* change defaults for upstream query range package

* update changelog

* remove max_tranfer_retries fix as it is covered in another PR, 4792

* increase query ingesters within by 1h

This provides an additional buffer on top of the max_chunk_age.

Co-authored-by: Owen Diehl <[email protected]>

* add comment reminder to remove query range config hack

Co-authored-by: Owen Diehl <[email protected]>

* rollback change to align_queries_with_step and parallelise_shardable_queries

* add upgrading docs

* re-enable parallelise_shardable_queries by default

* add parallelise_shardable_queries back to upgrading doc

Co-authored-by: Owen Diehl <[email protected]>
(cherry picked from commit 3091ccd)
Copy link
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆
Thank you for working on this 🙏

@trevorwhitney trevorwhitney merged commit a86f9a1 into release-2.4 Jan 12, 2022
@trevorwhitney trevorwhitney deleted the backport-5077-to-release-2.4 branch January 12, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants