Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a possible cancellation issue in the frontend #5075

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

cyriltovena
Copy link
Contributor

If all workers are busy and we cancel a request, then we will have to wait a worker to finish to see the cancellation.

We also don't need to close the work channel since it's buffered.

Signed-off-by: Cyril Tovena [email protected]

@cyriltovena cyriltovena requested a review from a team as a code owner January 7, 2022 14:31
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannykopping dannykopping merged commit a7795e5 into grafana:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants