Add rate limiting and metrics to hedging #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <[email protected]>
Signed-off-by: Cyril Tovena <[email protected]>
dannykopping
approved these changes
Dec 2, 2021
|
|
||
| func registerMetrics() { | ||
| totalHedgeRequests = promauto.NewCounter(prometheus.CounterOpts{ | ||
| Name: "hedged_requests_total", |
There was a problem hiding this comment.
Will these be prefixed with loki_?
Suggested change
| Name: "hedged_requests_total", | |
| Name: "hedged_requests_total", | |
| Namespace: "loki", |
There was a problem hiding this comment.
No I did not prefix them because I figure we might move this to dskit.
There was a problem hiding this comment.
I think we should prefix them until we move it to dskit. All of our other metrics have loki_ prefixes.
Signed-off-by: Cyril Tovena <[email protected]>
Signed-off-by: Cyril Tovena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cyril Tovena [email protected]
Checklist
CHANGELOG.mdabout the changes.