Ruler: Overwrite instead of merge remote-write headers #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
owen-d
approved these changes
Oct 7, 2021
dannykopping
pushed a commit
that referenced
this pull request
Oct 8, 2021
* Overwrite instead of merge remote-write headers Signed-off-by: Danny Kopping <[email protected]> * Allowing for clearing of headers when empty map is given Signed-off-by: Danny Kopping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Overwrites remote-write headers set as a per-tenant override, rather than merging with the base.
Which issue(s) this PR fixes:
Follow on from #4429
Special notes for your reviewer:
Checklist