Update fluent-plugin-loki documentation URLs #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated fluent-plugin-loki documentation links to point to new location. Original reference docs were moved in this [commit](grafana@6e67d1e#diff-04dc5b2136328a0dcb189df97734c7c72e5e1227fa0c03469a6ce608f32f1b66).
|
|
sandeepsukhani
approved these changes
Jun 22, 2021
KMiller-Grafana
approved these changes
Jun 22, 2021
| @@ -7,7 +7,7 @@ Loki has a [Fluentd](https://www.fluentd.org/) output plugin called | |||
| `fluent-plugin-grafana-loki` that enables shipping logs to a private Loki | |||
| instance or [Grafana Cloud](https://grafana.com/products/cloud/). | |||
|
|
|||
| The code source of the plugin is located in our [public repository](https://github.com/grafana/loki/tree/master/cmd/fluentd). | |||
| The code source of the plugin is located in our [public repository](https://github.com/grafana/loki/tree/main/clients/cmd/fluentd). | |||
There was a problem hiding this comment.
Suggested change
| The code source of the plugin is located in our [public repository](https://github.com/grafana/loki/tree/main/clients/cmd/fluentd). | |
| The plugin source code is in the [fluentd directory of the repository](https://github.com/grafana/loki/tree/main/clients/cmd/fluentd). |
| @@ -21,7 +21,7 @@ fluent-gem install fluent-plugin-grafana-loki | |||
|
|
|||
| ## Docker Image | |||
|
|
|||
| There is a Docker image `grafana/fluent-plugin-loki:master` which contains [default configuration files](https://github.com/grafana/loki/tree/master/fluentd/fluent-plugin-loki/docker/conf). By default, fluentd containers use the configurations but you can also specify your `fluentd.conf` with `FLUENTD_CONF` environment variable. | |||
| There is a Docker image `grafana/fluent-plugin-loki:master` which contains [default configuration files](https://github.com/grafana/loki/tree/main/clients/cmd/fluentd/docker/conf). By default, fluentd containers use the configurations but you can also specify your `fluentd.conf` with `FLUENTD_CONF` environment variable. | |||
There was a problem hiding this comment.
I find this paragraph confusing. Here's my suggested rewrite, given my questionable understanding of what was meant to be conveyed.
Suggested change
| There is a Docker image `grafana/fluent-plugin-loki:master` which contains [default configuration files](https://github.com/grafana/loki/tree/main/clients/cmd/fluentd/docker/conf). By default, fluentd containers use the configurations but you can also specify your `fluentd.conf` with `FLUENTD_CONF` environment variable. | |
| The Docker image `grafana/fluent-plugin-loki:master` contains [default configuration files](https://github.com/grafana/loki/tree/main/clients/cmd/fluentd/docker/conf). By default, fluentd containers use that default configuration. You can instead specify your `fluentd.conf` configuration file with a `FLUENTD_CONF` environment variable. |
Comment on lines
180
to
182
| ### url | ||
|
|
||
| The url of the Loki server to send logs to. When sending data the publish path (`../api/loki/v1/push`) will automatically be appended. |
There was a problem hiding this comment.
Please also update this prose, even though your PR did not originally touch this prose:
URL
The URL of the Loki server to send logs to. When sending data, the publish path (../api/loki/v1/push) will automatically be appended.
Comment on lines
180
to
182
| ### url | ||
|
|
||
| The url of the Loki server to send logs to. When sending data the publish path (`../api/loki/v1/push`) will automatically be appended. |
There was a problem hiding this comment.
Please also update this prose, even though your PR did not originally touch this prose.
Suggested change
| ### url | |
| The url of the Loki server to send logs to. When sending data the publish path (`../api/loki/v1/push`) will automatically be appended. | |
| ### URL | |
| The URL of the Loki server to send logs to. When sending data, the publish path (`../api/loki/v1/push`) will automatically be appended. |
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
stale
bot
removed
the
stale
KMiller-Grafana
added a commit
to KMiller-Grafana/loki
that referenced
this pull request
Aug 11, 2021
- Adds corrections from closed PR grafana#3880
slim-bean
pushed a commit
that referenced
this pull request
Aug 12, 2021
- Adds corrections from closed PR #3880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated fluent-plugin-loki documentation links to point to new location. Original reference docs were moved in this commit.
What this PR does / why we need it:
Update to fluent-plugin-loki documented.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist