Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker driver: Allow to provision external pipeline files to plugin #2054

Merged
merged 4 commits into from
May 8, 2020

Conversation

bkmit
Copy link
Contributor

@bkmit bkmit commented May 7, 2020

What this PR does / why we need it:
Add mounts section to docker plugin config.json.
This allow to make host directory with pipeline files accessable to docker driver plugin.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Sorry, something went wrong.

bkmit and others added 3 commits May 1, 2020 14:51

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@CLAassistant
Copy link

CLAassistant commented May 7, 2020

CLA assistant check
All committers have signed the CLA.

"destination": "/data",
"type": "none",
"options": ["bind", "ro"],
"settable": ["source", "destination"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you indent this please ?

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really love that change. @bkmit Thanks a lot for this !

There's just one nit if you can fix it before we merge.

Thank you !

@cyriltovena cyriltovena merged commit f5b9cff into grafana:master May 8, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* adding retry options for cassandra and updating docs

* adjusting some naming based on feedback

Signed-off-by: Ken Haines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants