Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test stats memchunk #1809

Merged
merged 2 commits into from
Mar 17, 2020
+71 −0
Merged

Test stats memchunk #1809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e7136d
Add a test for ensuring stats computed from memchunk are correct.
cyriltovena Mar 16, 2020
57f360e
Add some comment
cyriltovena Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions pkg/chunkenc/memchunk_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package chunkenc
import (
"bytes"
"context"
"encoding/binary"
"fmt"
"math"
"math/rand"
Expand All @@ -18,6 +19,7 @@ import (
"github.com/grafana/loki/pkg/iter"
"github.com/grafana/loki/pkg/logproto"
"github.com/grafana/loki/pkg/logql"
"github.com/grafana/loki/pkg/logql/stats"
)

var testEncoding = []Encoding{
Expand Down Expand Up @@ -397,6 +399,75 @@ func TestChunkSize(t *testing.T) {
}
}

func TestChunkStats(t *testing.T) {
c := NewMemChunk(EncSnappy)
first := time.Now()
entry := &logproto.Entry{
Timestamp: first,
Line: `ts=2020-03-16T13:58:33.459Z caller=dedupe.go:112 component=remote level=debug remote_name=3ea44a url=https:/blan.goo.net/api/prom/push msg=QueueManager.updateShardsLoop lowerBound=45.5 desiredShards=56.724401194003136 upperBound=84.5`,
}
inserted := 0
// fill the chunk with known data size.
for {
if !c.SpaceFor(entry) {
break
}
if err := c.Append(entry); err != nil {
t.Fatal(err)
}
inserted++
entry.Timestamp = entry.Timestamp.Add(time.Nanosecond)
}
expectedSize := (inserted * len(entry.Line)) + (inserted * 2 * binary.MaxVarintLen64)
ctx := stats.NewContext(context.Background())

it, err := c.Iterator(ctx, first.Add(-time.Hour), entry.Timestamp.Add(time.Hour), logproto.BACKWARD, logql.LineFilterFunc(func(line []byte) bool { return false }))
if err != nil {
t.Fatal(err)
}
for it.Next() {

}
if err := it.Close(); err != nil {
t.Fatal(err)
}
// test on a chunk filling up
s := stats.Snapshot(ctx, time.Since(first))
require.Equal(t, int64(expectedSize), s.Summary.TotalBytesProcessed)
require.Equal(t, int64(inserted), s.Summary.TotalLinesProcessed)

require.Equal(t, int64(expectedSize), s.Store.DecompressedBytes)
require.Equal(t, int64(inserted), s.Store.DecompressedLines)

b, err := c.Bytes()
if err != nil {
t.Fatal(err)
}

// test on a new chunk.
cb, err := NewByteChunk(b)
if err != nil {
t.Fatal(err)
}
ctx = stats.NewContext(context.Background())
it, err = cb.Iterator(ctx, first.Add(-time.Hour), entry.Timestamp.Add(time.Hour), logproto.BACKWARD, logql.LineFilterFunc(func(line []byte) bool { return false }))
if err != nil {
t.Fatal(err)
}
for it.Next() {

}
if err := it.Close(); err != nil {
t.Fatal(err)
}
s = stats.Snapshot(ctx, time.Since(first))
require.Equal(t, int64(expectedSize), s.Summary.TotalBytesProcessed)
require.Equal(t, int64(inserted), s.Summary.TotalLinesProcessed)

require.Equal(t, int64(expectedSize), s.Store.DecompressedBytes)
require.Equal(t, int64(inserted), s.Store.DecompressedLines)
}

func TestIteratorClose(t *testing.T) {
for _, enc := range testEncoding {
t.Run(enc.String(), func(t *testing.T) {
Expand Down