Query range should not support date where start == end. #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are always checking against start inclusively and not end, this means this type of query will always returns no result. Fixes grafana#1702, the frontend was not handling this type of query correctly. Signed-off-by: Cyril Tovena <[email protected]>
cyriltovena
commented
Feb 28, 2020
| @@ -149,6 +149,11 @@ func (h *splitByInterval) Do(ctx context.Context, r queryrange.Request) (queryra | |||
|
|
|||
| intervals := splitByTime(lokiRequest, interval) | |||
|
|
|||
| // no interval should not be processed by the frontend. | |||
There was a problem hiding this comment.
Just in case ! although this should never happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are always checking against start inclusively and not end, this means this type of query
will always returns no result.
Fixes #1702, the frontend was not handling this type of query correctly.
Signed-off-by: Cyril Tovena [email protected]