Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removed compactor options from minIO deployment #15367

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

Jayclifford345
Copy link
Contributor

What this PR does / why we need it:

Removed compactor settings from MinIO deployments. It was found that these caused MinIO setups to fail due to a bad configuration. Will work on adding these back in with further testing with MinIO when I get to the local deployment guide but for now it is safe to remove these for a better installation experience.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • [] Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 requested a review from a team as a code owner December 11, 2024 18:56
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 11, 2024
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler JStickler merged commit b7fe6bf into main Dec 11, 2024
59 checks passed
@JStickler JStickler deleted the hotfix-helm-minio branch December 11, 2024 19:24
loki-gh-app bot pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit b7fe6bf)
loki-gh-app bot pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit b7fe6bf)
loki-gh-app bot pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit b7fe6bf)
loki-gh-app bot pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit b7fe6bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants