Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: present DF bytes values in queryable format (backport release-3.3.x) #15320

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Dec 9, 2024

Backport f5d62bd from #15272


What this PR does / why we need it:

There are a lot of gotchyas with bytes in Loki. In the log line, bytes can be in many different formats, including spaces before the unit, no space before the unit, commas, decimals, basically anything that can be parsed by humanize.ParseBytes. However, for a query, we don't accept commas, and the unit must come directly after the number without a space.

This PR sanitizes bytes values returned by detected_fields/{field_name}/values to adhere to our rules for byte values in a query to make it easier for Explore Logs to construct queries from the values returned by this endpoint.

Which issue(s) this PR fixes:
Fixes #15052

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney merged commit 218ecbb into release-3.3.x Dec 9, 2024
59 checks passed
@trevorwhitney trevorwhitney deleted the backport-15272-to-release-3.3.x branch December 9, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant