feat: present DF bytes values in queryable format (backport release-3.3.x) #15320
+73
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f5d62bd from #15272
What this PR does / why we need it:
There are a lot of gotchyas with bytes in Loki. In the log line, bytes can be in many different formats, including spaces before the unit, no space before the unit, commas, decimals, basically anything that can be parsed by
humanize.ParseBytes
. However, for a query, we don't accept commas, and the unit must come directly after the number without a space.This PR sanitizes bytes values returned by
detected_fields/{field_name}/values
to adhere to our rules for byte values in a query to make it easier for Explore Logs to construct queries from the values returned by this endpoint.Which issue(s) this PR fixes:
Fixes #15052
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR