Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Copy chunks from ForSeries #14863

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Nov 11, 2024

What this PR does / why we need it:

We saw the following errors when using the split_by_series_chunks_size strategy:

ts=2024-11-11T13:49:22.314294574Z caller=spanlogger.go:116 user=fake level=error msg="failed downloading chunks" err="failed to load chunk '29/70e445e35a08d865/19312b76db3:1931326dfdf:141bf2e0': failed to get s3 object: NoSuchKey: ..."

Arguments for ForSeries callback should be captured as the chunks slice is reused on every call.

chks := ChunkMetasPool.Get()
defer ChunkMetasPool.Put(chks)

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts marked this pull request as ready for review November 11, 2024 14:15
@salvacorts salvacorts requested a review from a team as a code owner November 11, 2024 14:15
@salvacorts salvacorts merged commit bfc2890 into main Nov 11, 2024
59 checks passed
@salvacorts salvacorts deleted the salvacorts/planner-fix-reused-chunks branch November 11, 2024 15:52
@salvacorts salvacorts added type/bug Somehing is not working as expected backport k227 labels Nov 11, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 11, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k227 backport k228 size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants