Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): Bump netlify environment #14641

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

periklis
Copy link
Collaborator

What this PR does / why we need it:
Bingo environment expected go1.22 to install gen-crd-api-reference-docs-v0.0.3 but netlify is configured with go1.20. Solves:

10:51:17 AM: I1024 08:51:17.620955    6274 main.go:155] parsing go packages in directory github.com/grafana/loki/operator/api/loki/
10:51:17 AM: panic: runtime error: invalid memory address or nil pointer dereference
10:51:17 AM: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x80bf14]
10:51:17 AM: goroutine 1 [running]:
10:51:17 AM: k8s.io/gengo/parser.(*Builder).AddDirRecursive(0xc00014f720, {0x7ffc609cd9b7, 0x2a})
10:51:17 AM: 	/opt/buildhome/.gimme_cache/gopath/pkg/mod/k8s.io/[email protected]/parser/parse.go:234 +0x114
10:51:17 AM: main.parseAPIPackages({0x7ffc609cd9b7?, 0x2a?})
10:51:17 AM: 	/opt/buildhome/.gimme_cache/gopath/pkg/mod/github.com/!via!q/[email protected]/main.go:229 +0x49
10:51:17 AM: main.main()
10:51:17 AM: 	/opt/buildhome/.gimme_cache/gopath/pkg/mod/github.com/!via!q/[email protected]/main.go:156 +0x208
10:51:17 AM: make: *** [Makefile:317: docs/operator/api.md] Error 2

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Updates also the NODE_VERSION to use a modern and supported nodejs version.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis merged commit d4f8a2a into grafana:main Oct 29, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants