fix(operator): Disable log level discovery for OpenShift tenancy modes #14613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperimental
requested review from
periklis,
JoaoBraveCoding and
a team
as code owners
periklis
approved these changes
Oct 24, 2024
This was referenced Oct 28, 2024
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Loki recently introduced an automatic log level discovery, that aims to provide the log level of an entry if it was not provided. For OpenShift Logging this causes confusion because the collector already has a log level discovery included, but it uses a different field, so there are sometimes two disagreeing log levels on an event which is confusing.
This PR disables the log level discovery for OpenShift tenancy modes to avoid this issue.
Which issue(s) this PR fixes:
LOG-6286
Special notes for your reviewer:
openshift-networktenancy mode, because that mode uses Loki for non-logging data, which does not need this field.Checklist
CONTRIBUTING.mdguide (required)