Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use GH app for helm workflows #14269

Merged
merged 3 commits into from
Sep 26, 2024
Merged

ci: use GH app for helm workflows #14269

merged 3 commits into from
Sep 26, 2024

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

Change helm workflows to use GH App for auth.

Which issue(s) this PR fixes:
Fixes #14258

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner September 25, 2024 17:36
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@trevorwhitney trevorwhitney merged commit 923a3e4 into main Sep 26, 2024
61 checks passed
@trevorwhitney trevorwhitney deleted the fix-14258 branch September 26, 2024 14:46
@Starefossen
Copy link
Contributor

CI is failing with Error: Input required and not supplied: app-id ref. https://github.com/grafana/loki/actions/runs/11066924233/job/30749176890?pr=14281

@trevorwhitney
Copy link
Collaborator Author

hmm, app-id is definitely being provided and it's passing some builds so something for use to keep an eye on I guess?

jeschkies pushed a commit to jeschkies/loki that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm release CI broken?
3 participants