-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Memcached persistence #14049
fix: Memcached persistence #14049
Conversation
d2c1b87
to
b998050
Compare
hey @chaudum please review this when you can |
why is this taking ages to merge? |
I don't think ext_wbuf_size should be hard coded. Users should be able to adjust this if needed |
I agree @eric-engberg but I could not think of a way to:
any suggestions on how to do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreZiviani Thanks! LGMT
I will merge once the merge conflicts are resolved.
b998050
to
9cac702
Compare
thanks @chaudum , done |
Just add it as a field in the values file. Under persistence maybe? |
@eric-engberg Do you want to do that in a separate PR? |
since this is a somewhat complex and advanced usage I believe we shouldn't add any options automatically (I had some issued with this on loki-distributed helm), I've added it on previous PR because it looked like it was going to be simple but it is not |
@AndreZiviani Seems like the branch needs to be updated again to resolve the conflicts. I'm ready to merge then. |
9cac702
to
14eaa64
Compare
@chaudum done |
also looks like the CI for helm release is broken |
Thanks @AndreZiviani ! |
release still failing btw |
* Memcached must create a file smaller than disk size * `ext_wbuf_size` must be bigger than max item size and be divisible by `wbuf_size` which is 64 by default * Add pod permissions to access local volume
* Memcached must create a file smaller than disk size * `ext_wbuf_size` must be bigger than max item size and be divisible by `wbuf_size` which is 64 by default * Add pod permissions to access local volume
* Memcached must create a file smaller than disk size * `ext_wbuf_size` must be bigger than max item size and be divisible by `wbuf_size` which is 64 by default * Add pod permissions to access local volume
What this PR does / why we need it:
Fixes the usage of persistence on Memcached:
ext_wbuf_size
must be bigger than max item size and be divisible bywbuf_size
which is 64 by defaultWhich issue(s) this PR fixes:
Fixes #14028
Related #13619
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR