fix(deps): update module github.com/gorilla/websocket to v1.5.3 #13873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
deps-update/github.aaakk.us.kg-gorilla-websocket-1.x
branch
from
f146535 to
7f09f95
Compare
paul1r
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
lgtm. Spent time reviewing this and looking at the underlying project history. There was a fix/set of fixes that added extensive logging that was unexpected for an underlying infra package. This was left for upwards of 8 months, leading to an unsettled feeling in the community.
These changes have since been reverted, and this update for Loki is minor as a result. The change from 1.5.0 to 1.5.3 contains a small amount of better error handling, and a couple of small secure protocol handshake changes.
paul1r
deleted the
deps-update/github.aaakk.us.kg-gorilla-websocket-1.x
branch
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
…ana#13873) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
…ana#13873) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.5.0->v1.5.3Release Notes
gorilla/websocket (github.com/gorilla/websocket)
v1.5.3Compare Source
Important change
This reverts the websockets package back to gorilla/websocket@931041c
What's Changed
SetCloseHandler()by @nak3 in https://github.com/gorilla/websocket/pull/863New Contributors
Full Changelog: gorilla/websocket@v1.5.1...v1.5.3
v1.5.2Compare Source
What's Changed
SetCloseHandler()by @nak3 in https://github.com/gorilla/websocket/pull/863New Contributors
Full Changelog: gorilla/websocket@v1.5.1...v1.5.2
v1.5.1Compare Source
What's Changed
New Contributors
Full Changelog: gorilla/websocket@v1.5.0...v1.5.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.