chore: treat datasample queries the same as limited queries #13700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
datasample queries are use by Grafana for query auto complete as well as "logs sample" on metric queries.
they are generally only helpful if they can return quickly
similar logic here to how we handle "limited" queries (log queries with no label filter)
We shouldn't process these so aggressively in parallel (only do one split by time, at a time) because it's both wasteful and doesn't return a faster result when we only need 10 log lines.
Comparison periods (left with test image, right same time period previous 4 weeks)
Will need to see this run for a few more weeks to really confirm if this impact is consistent (maybe it was less querying during the test week), but generally this looks to be a big benefit
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR