-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mixins): Allow hiding useless rows in loki-operational #13646
feat(mixins): Allow hiding useless rows in loki-operational #13646
Conversation
Signed-off-by: QuentinBisson <[email protected]>
6d09cc7
to
c765862
Compare
hey @cstyan do you know if I could have some reviews on my mixins PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QuentinBisson Sorry, I was away on vacation for a few weeks.
Tested this one locally and it looks good to me! We'll definitely make use of this ourselves to hide some rows that are no longer relevant to us.
@cstyan no worries, I know you're really busy :) Thank you for the reviews. I feel bad that I have to ping you for those actually. On another topic, as I'm in the process a becoming a Grafana Champion, do you think it would make sense that I help out in the maintenance of the mixins and maybe helm chart for loki as we use them quite heavily? This might help you with the high load of open source PRs :) I'll merge the ones in conflicts today |
No worries at all, I appreciate you keeping up with the reminders, it can be easy to lose track of some PRs!
That's great to hear! I was actually going to check internally if we could do anything like send you a shirt or something, LMK if they don't do that as apart of the Grafana Champion program. We would love help maintaining the mixins and helm charts, so by all means go for it 👍 |
Do you know if it is possible to be added to the codeowners for the mixins and helm chart or would you prefer some first thoughts on the PRs and a ping so someone in your team a second look and approve? What do you think would be the best course of action? |
What this PR does / why we need it:
Loki operationnal exposes a lot of rows that are usually not used because we do not send data to 5 different storage backends so it makes sense to be able to hide the rows we do not need to make for a cleaner dashboard
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR