Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Use correct key to populate blockscache at startup #13624

Merged
merged 1 commit into from
Jul 23, 2024

Commits on Jul 23, 2024

  1. fix(blooms): Use correct key to populate blockscache at startup

    The cache key for block directories in the blockscache are the block's
    address without the directory prefix. This is how the directory is put
    to the LRU cache after downloading and extracing the block tarball.
    
    This PR fixes the incorrect cache key used to populate the cache from
    disk on startup, which contained the filesystem directory prefix.
    
    Since the cached item from startup is never used, it gets evicted first
    in case of a full cache, or due to its TTL. This causes also the
    underlying directory on disk to be deleted, which can however still be
    referenced from the correct cache key for that directory from a later
    download.
    That caused the error "getting index reader: opening series file: open
    /path/to/block/series: no such file or directory" when trying to query
    the block, because the correct cache key was still present.
    
    Signed-off-by: Christian Haudum <[email protected]>
    chaudum committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3d080b8 View commit details
    Browse the repository at this point in the history