Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make detected fields work for both json and proto #12682

Merged
merged 13 commits into from
Apr 19, 2024
Prev Previous commit
Next Next commit
fix: ineffectual assignment
trevorwhitney committed Apr 19, 2024

Verified

This commit was signed with the committer’s verified signature.
myii Imran Iqbal
commit efafd51f2192e888c468b7d717dd1ece379239d6
4 changes: 4 additions & 0 deletions integration/explore_logs_test.go
Original file line number Diff line number Diff line change
@@ -148,13 +148,15 @@ func Test_ExploreLogsApis(t *testing.T) {
u.Path = "/loki/api/v1/detected_fields"
u.RawQuery = v.Encode()
dfResp, err := cliQueryFrontend.Get(u.String())
require.NoError(t, err)
defer dfResp.Body.Close()

buf, err := io.ReadAll(dfResp.Body)
require.NoError(t, err)

var detectedFieldResponse DetectedFieldResponse
err = json.Unmarshal(buf, &detectedFieldResponse)
require.NoError(t, err)

require.Equal(t, 2, len(detectedFieldResponse.Fields))

@@ -188,13 +190,15 @@ func Test_ExploreLogsApis(t *testing.T) {
u.Path = "/loki/api/v1/detected_fields"
u.RawQuery = v.Encode()
dfResp, err := cliQueryFrontend.Get(u.String())
require.NoError(t, err)
defer dfResp.Body.Close()

buf, err := io.ReadAll(dfResp.Body)
require.NoError(t, err)

var detectedFieldResponse DetectedFieldResponse
err = json.Unmarshal(buf, &detectedFieldResponse)
require.NoError(t, err)

require.Equal(t, 2, len(detectedFieldResponse.Fields))