Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add missing aliases for moved pages #12580

Merged
merged 4 commits into from
Apr 12, 2024
Merged

docs: add missing aliases for moved pages #12580

merged 4 commits into from
Apr 12, 2024

Conversation

JStickler
Copy link
Contributor

What this PR does / why we need it:
I realized that I'd moved/renamed these pages and not included the aliases for redirects.

@JStickler JStickler added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 11, 2024
@JStickler JStickler requested a review from jdbaldry April 11, 2024 17:41
@JStickler JStickler requested a review from a team as a code owner April 11, 2024 17:41
jdbaldry
jdbaldry reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it looks like doc-validator is mean because it doesn't know that those headings are gonna come in from the shared file. I can fix this tomorrow.

jdbaldry
jdbaldry reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've already added the alias into this file?

@JStickler
Copy link
Contributor Author

JStickler commented Apr 11, 2024 •
edited
Loading

I think I've already added the alias into this file?

Did you just update the branch? I pulled from main, and it didn't have an alias. ¯_(ツ)_/¯

jdbaldry
jdbaldry requested changes Apr 12, 2024
View reviewed changes
jdbaldry
jdbaldry approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing :)

@JStickler JStickler merged commit 5e21ffa into main Apr 12, 2024
12 checks passed
@JStickler JStickler deleted the 2024.04.11_alias branch April 12, 2024 12:06
grafanabot pushed a commit that referenced this pull request Apr 12, 2024
@JStickler @grafana-delivery-bot
docs: add missing aliases for moved pages (#12580)
ba5ceab 
Co-authored-by: Jack Baldry <[email protected]>
(cherry picked from commit 5e21ffa)
@grafanabot grafanabot mentioned this pull request Apr 12, 2024
Merged
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@JStickler @jdbaldry @rhnasc
docs: add missing aliases for moved pages (grafana#12580)
943f903 
Co-authored-by: Jack Baldry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbaldry jdbaldry jdbaldry approved these changes

Assignees
No one assigned
Labels
backport release-3.0.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JStickler @jdbaldry