fix(operator): Fix duplicate operator metrics due to ServiceMonitor selector #12216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperimental
changed the title
periklis
approved these changes
Mar 14, 2024
periklis
added a commit
to periklis/loki
that referenced
this pull request
Mar 14, 2024
…elector (grafana#12216) Co-authored-by: Periklis Tsirakidis <[email protected]>
periklis
added a commit
to periklis/loki
that referenced
this pull request
Mar 14, 2024
…elector (grafana#12216) Co-authored-by: Periklis Tsirakidis <[email protected]>
periklis
added a commit
to periklis/loki
that referenced
this pull request
Mar 14, 2024
…elector (grafana#12216) Co-authored-by: Periklis Tsirakidis <[email protected]>
openshift-merge-bot bot
added a commit
to openshift/loki
that referenced
this pull request
Mar 15, 2024
[release-5.6] Backport PR grafana#12164 and grafana#12216
openshift-merge-bot bot
added a commit
to openshift/loki
that referenced
this pull request
Mar 15, 2024
[release-5.8] Backport PR grafana#12164 and grafana#12216
openshift-merge-bot bot
added a commit
to openshift/loki
that referenced
this pull request
Mar 15, 2024
[release-5.7] Backport PR grafana#12164 and grafana#12216
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…elector (grafana#12216) Co-authored-by: Periklis Tsirakidis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
During installation of Loki Operator it creates multiple services pointing to the operator used for different purposes. The
ServiceMonitorused for getting metrics from the operator contains a selector that currently matches more than one of these services. This causes Prometheus to generate multiple targets for the same operator instance, leading to duplicate metrics.This PR fixes this issue by adding an explicit "metrics label" to one of the services and updating the
ServiceMonitorto just match that specific service.Which issue(s) this PR fixes:
LOG-5212
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdated