-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Convert line filter expressions to a set of bloom tests #12035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvacorts
changed the title
Convert line filter expressions to a set of bloom tests
feat: Convert line filter expressions to a set of bloom tests
Feb 22, 2024
8 tasks
salvacorts
force-pushed
the
salvacorts/bloom-searches
branch
from
February 23, 2024 10:17
5fe914b
to
978a76f
Compare
chaudum
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good!
chaudum
approved these changes
Feb 23, 2024
owen-d
approved these changes
Feb 23, 2024
8 tasks
This was referenced Mar 25, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces:
BloomTest
with two test methods that take a bloom as an argument and returns a boolean. True if the test passes with the given bloom.FiltersToBloomTest
that given a set ofLineFilterExpr
, it returns aBloomTest
.The logic in this PR is not yet used anywhere since we need to do some refactoring to be able to use it. These refactorings will be done on a set of follow-up PRs:1. Passsyntax.LineFilterExpr
instead ofsyntax.LineFilter
withlogproto.FilterChunkRefRequest
2. Create BloomTest from the line filters passed along throughlogproto.FilterChunkRefRequest
and modify the fused querier to use the resultingBloomTest
.3. Map regex line filters to
BloomTest
when possible. The logic would be pretty similar to what's done in thesimplify
function at pkg/logql/log/filter.go. We can probably extract the simplification logic into [pkg/util/regex.go].(https://github.com/grafana/loki/blob/5a08a6bcb9ecc816328cb7859bbdcc7cf9d004c5/pkg/util/regex.go)Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR