Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Fix chart mTLS implementation #12025

Merged
merged 17 commits into from
Feb 22, 2024

Conversation

DylanGuedes
Copy link
Contributor

@DylanGuedes DylanGuedes commented Feb 21, 2024

What this PR does / why we need it:
Fix mTLS capabilities on our grafana/loki chart for microservices through the following changes:

  • Add a new ssl key to the nginxConfig section. When ssl is true we append ssl to the listen directives.
  • Add a new schema key to the nginxConfig section. schema is http by default but can be https. It is used by nginx when creating loki component URLs. For instance, requests to /loki/v1/push use http by default, but by changing this, they can use https. Used for internal mTLS.
  • Change internal nginx URLs to work for both, distributed and SSD modes
  • Fix distributor service targetPort (missing metrics suffix)
  • Add extraVolumes and extraVolumeMounts to canaries deployment. They're useful when configuring mTLS for canaries
  • Chnage index_gateway to run mode=simple by default
  • Add tail_proxy_url to the helmchar default values
  • I'm also adding a new distributed-tls file to show users how to configure the helmchart to work with mTLS.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@DylanGuedes DylanGuedes changed the title Add nginx microserviecs Helm: Fix chart mTLS implementation Feb 22, 2024
@DylanGuedes DylanGuedes merged commit 3f5f69e into distributed-helm-chart Feb 22, 2024
8 of 10 checks passed
@DylanGuedes DylanGuedes deleted the add-nginx-microserviecs branch February 22, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant