-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: Fix chart mTLS implementation #12025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Components were expecting the port name to be `http` instead of `http-metrics`.
… add-nginx-microserviecs
DylanGuedes
force-pushed
the
add-nginx-microserviecs
branch
from
February 21, 2024 19:09
e66276f
to
ad63ded
Compare
DylanGuedes
force-pushed
the
add-nginx-microserviecs
branch
from
February 21, 2024 19:10
ad63ded
to
68da415
Compare
DylanGuedes
changed the title
Add nginx microserviecs
Helm: Fix chart mTLS implementation
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix mTLS capabilities on our
grafana/loki
chart for microservices through the following changes:ssl
key to thenginxConfig
section. Whenssl
is true we appendssl
to thelisten
directives.schema
key to thenginxConfig
section.schema
ishttp
by default but can behttps
. It is used by nginx when creating loki component URLs. For instance, requests to/loki/v1/push
usehttp
by default, but by changing this, they can usehttps
. Used for internal mTLS.metrics
suffix)extraVolumes
andextraVolumeMounts
to canaries deployment. They're useful when configuring mTLS for canariesmode=simple
by defaulttail_proxy_url
to the helmchar default valuesWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: