Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release-2.9.x): frontend: Use net.JoinHostPort to support IPv6 addresses (#10650) #11870

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix(release-2.9.x): frontend: Use net.JoinHostPort to support IPv6 addresses (#10650) #11870

merged 1 commit into from
Mar 4, 2024
+13 −10

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Feb 5, 2024

What this PR does / why we need it:
Manual backport for #10650

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Feb 5, 2024
@periklis periklis requested a review from a team as a code owner February 5, 2024 20:29
@periklis periklis mentioned this pull request Feb 5, 2024
Closed
JoaoBraveCoding
JoaoBraveCoding approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I noticed no CHANGELOG update, maybe it makes sense adding a line there

@periklis
Copy link
Collaborator Author

periklis commented Feb 6, 2024

lgtm, I noticed no CHANGELOG update, maybe it makes sense adding a line there

I have to figure out how the correct labeling on GH is meant to be used due to the new release process.

@periklis periklis requested review from chaudum and removed request for dannykopping February 12, 2024 19:54
@dbazhal
Copy link

dbazhal commented Feb 22, 2024

Hi guys! Can this please be checked?) @chaudum

@chaudum
Copy link
Contributor

chaudum commented Feb 28, 2024

@periklis Can you rebase the PR against release-2.9.x to trigger the new GH actions?

@matthewpi @periklis
frontend: Use net.JoinHostPort to support IPv6 addresses (grafana#1…
be01516 
…0650)

Signed-off-by: Matthew Penner <[email protected]>
Co-authored-by: Periklis Tsirakidis <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit a91f3f1)
@periklis periklis force-pushed the backport-10650-to-release-2.9.x branch from e6e7fd2 to be01516 Compare February 29, 2024 08:17
@periklis periklis changed the title [release-2.9.x] fix: frontend: Use net.JoinHostPort to support IPv6 addresses (#10650) fix(release-2.9.x): frontend: Use net.JoinHostPort to support IPv6 addresses (#10650) Feb 29, 2024
@periklis
Copy link
Collaborator Author

@chaudum Rebased! Can you take a look please

@periklis periklis merged commit 7def3b4 into grafana:release-2.9.x Mar 4, 2024
8 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 4, 2024
Merged
@MichelHollands MichelHollands mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

@chaudum chaudum chaudum approved these changes

Assignees

@periklis periklis

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@periklis @dbazhal @chaudum @JoaoBraveCoding @matthewpi